fix: country code selector

src/features/authentication/components/CountryCodeSelector.tsx

@@ -17,6 +17,8 @@ import { countries, type Country } from '../../../data/countries';
 import type { CountryCode } from '@/types/commonTypes';
 import { Icon } from '@rkheftan/harmony-ui';
 import { LTRBox } from '@/components/common/LTRBox';
+import { Virtuoso } from 'react-virtuoso';
+
 interface CountryCodeSelectorProps {
   show: boolean;
   value: CountryCode;
@@ -25,10 +27,6 @@ interface CountryCodeSelectorProps {
   onCloseFocusRef: RefObject<HTMLInputElement | null>;
 }
 
-/**
- * An animated country code adornment that fades and slides into view.
- * Its visibility is controlled by the `show` prop.
- */
 export function CountryCodeSelector({
   show,
   value,
@@ -46,18 +44,14 @@ export function CountryCodeSelector({
   const selectedCountry =
     countries.find((c) => c.phone === value) || countries[0];
 
-  const handleClick = () => {
-    setAnchorEl(menuAnchor);
-  };
+  const handleClick = () => setAnchorEl(menuAnchor);
 
   const handleClose = () => {
-    setTimeout(() => {
-      setAnchorEl(null);
-    }, 0);
+    setTimeout(() => setAnchorEl(null), 0);
     setTimeout(() => {
       onCloseFocusRef.current?.focus();
     }, 100);
-    setSearchTerm(''); // Reset search on close
+    setSearchTerm('');
   };
 
   const handleSelect = (country: Country) => {
@@ -66,7 +60,6 @@ export function CountryCodeSelector({
   };
 
   const handleMenuEntered = () => {
-    // Focus the input field after the menu has finished opening
     searchInputRef.current?.focus();
   };
 
@@ -74,55 +67,51 @@ export function CountryCodeSelector({
     () =>
       countries.filter(
         (country) =>
-          t(country.label).toLowerCase().includes(searchTerm.toLowerCase()) ||
+          t(country.label, { ns: 'country' })
+            .toLowerCase()
+            .includes(searchTerm.toLowerCase()) ||
           country.label.toLowerCase().includes(searchTerm.toLowerCase()) ||
           country.phone.includes(searchTerm),
       ),
-    [searchTerm],
+    [searchTerm, t],
+  );
+
+  const initialIndex = Math.max(
+    0,
+    filteredCountries.findIndex((c) => c.phone === value),
   );
 
   return (
     <InputAdornment
       position={i18n.dir() === 'rtl' ? 'start' : 'end'}
-      sx={{
-        mx: 0,
-      }}
+      sx={{ mx: 0 }}
     >
       <Box
         onClick={handleClick}
         sx={{
-          // Animate width and opacity based on the 'show' prop
           width: show ? 'auto' : 0,
           opacity: show ? 1 : 0,
           transition: (theme) =>
             theme.transitions.create(['width', 'opacity'], {
               duration: theme.transitions.duration.standard,
             }),
-
-          // Prevent content from wrapping or spilling out during animation
           overflow: 'hidden',
           whiteSpace: 'nowrap',
-
-          // layout styles
           height: '100%',
           display: 'flex',
           alignItems: 'center',
           gap: 0.25,
           pl: show ? 0.25 : 0,
-
-          '&:hover': {
-            cursor: 'pointer',
-          },
+          '&:hover': { cursor: 'pointer' },
         }}
       >
-        {/* This inner Box prevents the content from being squeezed during the transition */}
         <Icon Component={ArrowDown2} size="medium" variant="Bold" />
 
         <Typography
           variant="body1"
           color="text.primary"
           component="div"
-          sx={{ direction: 'rtl' }} // TODO: need to fixed for both en and fa
+          sx={{ direction: 'rtl' }}
         >
           {value}
         </Typography>
@@ -133,7 +122,6 @@ export function CountryCodeSelector({
           style={{
             height: '1.5rem',
             width: '1.5rem',
-            // TODO: Check alignment for better styling definition
             marginTop: '-2px',
             marginRight: '4px',
           }}
@@ -146,23 +134,15 @@ export function CountryCodeSelector({
           slotProps={{
             list: {
               sx: {
-                // Set the width to match the anchor element's width
                 width: menuWidth,
                 height: '18.75rem',
+                p: 0,
               },
             },
-            transition: {
-              onEntered: handleMenuEntered,
-            },
-          }}
-          anchorOrigin={{
-            vertical: 'bottom',
-            horizontal: 'left',
-          }}
-          transformOrigin={{
-            vertical: 'top',
-            horizontal: 'left',
+            transition: { onEntered: handleMenuEntered },
           }}
+          anchorOrigin={{ vertical: 'bottom', horizontal: 'left' }}
+          transformOrigin={{ vertical: 'top', horizontal: 'left' }}
         >
           <Box
             sx={{
@@ -183,8 +163,8 @@ export function CountryCodeSelector({
             />
           </Box>
 
-          {/* Can improve preformance with using virtual scrolling */}
-          <Box sx={{ width: '100%', maxHeight: '14.75rem', overflow: 'auto' }}>
+          {/* Virtualized country list */}
+          <Box sx={{ width: '100%', height: '14.75rem' }}>
             {filteredCountries.length === 0 ? (
               <MenuItem disabled>
                 <ListItem>
@@ -194,65 +174,35 @@ export function CountryCodeSelector({
                 </ListItem>
               </MenuItem>
             ) : (
-              filteredCountries.map((country) => (
-                <MenuItem
-                  key={country.code}
-                  selected={country.phone === value}
-                  onClick={() => handleSelect(country)}
-                >
-                  <ListItemIcon>
-                    <ReactCountryFlag
-                      countryCode={country.code}
-                      svg
-                      style={{
-                        height: '1.125rem',
-                        width: '1.125rem',
-                      }}
+              <Virtuoso
+                style={{ height: '100%', width: '100%' }}
+                data={filteredCountries}
+                initialTopMostItemIndex={initialIndex}
+                itemContent={(_, country) => (
+                  <MenuItem
+                    key={country.code}
+                    selected={country.phone === value}
+                    onClick={() => handleSelect(country)}
+                  >
+                    <ListItemIcon>
+                      <ReactCountryFlag
+                        countryCode={country.code}
+                        svg
+                        style={{ height: '1.125rem', width: '1.125rem' }}
+                      />
+                    </ListItemIcon>
+                    <ListItemText
+                      primary={t(country.label, { ns: 'country' })}
                     />
-                  </ListItemIcon>
-                  <ListItemText primary={t(country.label, { ns: 'country' })} />
-                  <Typography color="text.secondary">
-                    <Typography>
+                    <Typography color="text.secondary">
                       <LTRBox>{country.phone}</LTRBox>
                     </Typography>
-                  </Typography>
-                </MenuItem>
-              ))
+                  </MenuItem>
+                )}
+                computeItemKey={(_, c) => c.code}
+              />
             )}
           </Box>
-
-          {/* virtual scrolling  */}
-          {/* <Virtuoso
-            style={{ height: '14.75rem' }} // Adjust height to account for the search bar
-            data={filteredCountries}
-            components={{
-              EmptyPlaceholder: () => (
-                <MenuItem disabled>
-                  <ListItemText>{t('messages.noResultFound')}</ListItemText>
-                </MenuItem>
-              ),
-            }}
-            initialTopMostItemIndex={countries.indexOf(selectedCountry)}
-            itemContent={(_, country) => (
-              <MenuItem
-                key={country.code}
-                selected={country.phone === value}
-                onClick={() => handleSelect(country)}
-              >
-                <ListItemIcon>
-                  <ReactCountryFlag
-                    countryCode={country.code}
-                    svg
-                    style={{ fontSize: '1.25em', lineHeight: '1.25em' }}
-                  />
-                </ListItemIcon>
-                <ListItemText primary={country.label} />
-                <Typography variant="body2" color="text.secondary">
-                  {country.phone}
-                </Typography>
-              </MenuItem>
-            )}
-          /> */}
         </Menu>
       </Box>
     </InputAdornment>