7 Commits

Author SHA1 Message Date
Nick Cipollo
6c34249ffc Prepare 1.6.1 release
Some checks failed
PR Checks / check_pr (push) Has been cancelled
2020-03-05 13:25:53 -05:00
Nick Cipollo
c4e12dcecf Build debug 2020-03-05 13:22:45 -05:00
Nick Cipollo
791611e03e Tiny logging tweek 2020-03-05 13:12:22 -05:00
Nick Cipollo
2ea88b1f32 Add retry for uploading artifact (#13) 2020-03-05 11:39:02 -05:00
Nick Cipollo
d57d57cad2 Fixes #12 Artifacts will now be replaced 2020-03-02 22:20:41 -05:00
Nick Cipollo
767a5edcf4 Fix tests 2020-01-02 23:46:48 -05:00
Nick Cipollo
cffd02c48e Add artifact upload error handling 2020-01-02 23:31:20 -05:00
17 changed files with 477 additions and 215 deletions

View File

@@ -13,6 +13,7 @@ This action will create a github release and optionally upload an artifact to it
- **draft**: Optionally marks this release as a draft release. Set to `true` to enable. - **draft**: Optionally marks this release as a draft release. Set to `true` to enable.
- **name**: An optional name for the release. If this is omitted the tag will be used. - **name**: An optional name for the release. If this is omitted the tag will be used.
- **prerelease**: Optionally marks this release as prerelease. Set to true to enable. - **prerelease**: Optionally marks this release as prerelease. Set to true to enable.
- **replacesArtifacts**: Indicates if existing release artifacts should be replaced. Defaults to true.
- **tag**: An optional tag for the release. If this is omitted the git ref will be used (if it is a tag). - **tag**: An optional tag for the release. If this is omitted the git ref will be used (if it is a tag).
- **token**: (**Required**) The Github token. Typically this will be `${{ secrets.GITHUB_TOKEN }}`. - **token**: (**Required**) The Github token. Typically this will be `${{ secrets.GITHUB_TOKEN }}`.

View File

@@ -5,7 +5,9 @@ import { Releases } from "../src/Releases";
import { ArtifactUploader } from "../src/ArtifactUploader"; import { ArtifactUploader } from "../src/ArtifactUploader";
const createMock = jest.fn() const createMock = jest.fn()
const deleteMock = jest.fn()
const getMock = jest.fn() const getMock = jest.fn()
const listArtifactsMock = jest.fn()
const listMock = jest.fn() const listMock = jest.fn()
const updateMock = jest.fn() const updateMock = jest.fn()
const uploadMock = jest.fn() const uploadMock = jest.fn()
@@ -21,6 +23,8 @@ const draft = true
const id = 100 const id = 100
const name = 'name' const name = 'name'
const prerelease = true const prerelease = true
const releaseId = 101
const replacesArtifacts = true
const tag = 'tag' const tag = 'tag'
const token = 'token' const token = 'token'
const url = 'http://api.example.com' const url = 'http://api.example.com'
@@ -51,7 +55,7 @@ describe("Action", () => {
await action.perform() await action.perform()
expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease) expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease)
expect(uploadMock).toBeCalledWith(artifacts, url) expect(uploadMock).toBeCalledWith(artifacts, releaseId, url)
}) })
it('creates release if no draft releases', async () => { it('creates release if no draft releases', async () => {
@@ -67,7 +71,7 @@ describe("Action", () => {
await action.perform() await action.perform()
expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease) expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease)
expect(uploadMock).toBeCalledWith(artifacts, url) expect(uploadMock).toBeCalledWith(artifacts, releaseId, url)
}) })
@@ -77,7 +81,7 @@ describe("Action", () => {
await action.perform() await action.perform()
expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease) expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease)
expect(uploadMock).toBeCalledWith(artifacts, url) expect(uploadMock).toBeCalledWith(artifacts, releaseId, url)
}) })
it('throws error when create fails', async () => { it('throws error when create fails', async () => {
@@ -148,7 +152,7 @@ describe("Action", () => {
} }
expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease) expect(createMock).toBeCalledWith(tag, body, commit, draft, name, prerelease)
expect(uploadMock).toBeCalledWith(artifacts, url) expect(uploadMock).toBeCalledWith(artifacts, releaseId, url)
}) })
it('updates draft release', async () => { it('updates draft release', async () => {
@@ -165,7 +169,7 @@ describe("Action", () => {
await action.perform() await action.perform()
expect(updateMock).toBeCalledWith(id, tag, body, commit, draft, name, prerelease) expect(updateMock).toBeCalledWith(id, tag, body, commit, draft, name, prerelease)
expect(uploadMock).toBeCalledWith(artifacts, url) expect(uploadMock).toBeCalledWith(artifacts, releaseId, url)
}) })
@@ -185,7 +189,7 @@ describe("Action", () => {
await action.perform() await action.perform()
expect(updateMock).toBeCalledWith(id, tag, body, commit, draft, name, prerelease) expect(updateMock).toBeCalledWith(id, tag, body, commit, draft, name, prerelease)
expect(uploadMock).toBeCalledWith(artifacts, url) expect(uploadMock).toBeCalledWith(artifacts, releaseId, url)
}) })
@@ -199,15 +203,18 @@ describe("Action", () => {
const MockReleases = jest.fn<Releases, any>(() => { const MockReleases = jest.fn<Releases, any>(() => {
return { return {
create: createMock, create: createMock,
deleteArtifact: deleteMock,
getByTag: getMock, getByTag: getMock,
listArtifactsForRelease: listArtifactsMock,
listReleases: listMock, listReleases: listMock,
update: updateMock, update: updateMock,
uploadArtifact: uploadMock uploadArtifact: jest.fn()
} }
}) })
createMock.mockResolvedValue({ createMock.mockResolvedValue({
data: { data: {
id: releaseId,
upload_url: url upload_url: url
} }
}) })
@@ -221,6 +228,7 @@ describe("Action", () => {
}) })
updateMock.mockResolvedValue({ updateMock.mockResolvedValue({
data: { data: {
id: releaseId,
upload_url: url upload_url: url
} }
}) })
@@ -235,6 +243,7 @@ describe("Action", () => {
draft: draft, draft: draft,
name: name, name: name,
prerelease: prerelease, prerelease: prerelease,
replacesArtifacts: replacesArtifacts,
tag: tag, tag: tag,
token: token, token: token,
readArtifact: () => artifactData readArtifact: () => artifactData

View File

@@ -1,6 +1,7 @@
import { Artifact } from "../src/Artifact" import { Artifact } from "../src/Artifact"
import { GithubArtifactUploader } from "../src/ArtifactUploader" import { GithubArtifactUploader } from "../src/ArtifactUploader"
import { Releases } from "../src/Releases"; import { Releases } from "../src/Releases";
import { RequestError } from '@octokit/request-error'
const artifacts = [ const artifacts = [
new Artifact('a/art1'), new Artifact('a/art1'),
@@ -8,9 +9,13 @@ const artifacts = [
] ]
const fileContents = Buffer.from('artful facts', 'utf-8') const fileContents = Buffer.from('artful facts', 'utf-8')
const contentLength = 42 const contentLength = 42
const uploadMock = jest.fn() const releaseId = 100
const url = 'http://api.example.com' const url = 'http://api.example.com'
const deleteMock = jest.fn()
const listArtifactsMock = jest.fn()
const uploadMock = jest.fn()
jest.mock('fs', () => { jest.mock('fs', () => {
return { return {
readFileSync: () => fileContents, readFileSync: () => fileContents,
@@ -19,27 +24,184 @@ jest.mock('fs', () => {
}) })
describe('ArtifactUploader', () => { describe('ArtifactUploader', () => {
it('uploads artifacts', () => { beforeEach(() => {
const uploader = createUploader() deleteMock.mockClear()
listArtifactsMock.mockClear()
uploader.uploadArtifacts(artifacts, url) uploadMock.mockClear()
})
it('replaces all artifacts', async () => {
mockDeleteSuccess()
mockListWithAssets()
mockUploadArtifact()
const uploader = createUploader(true)
await uploader.uploadArtifacts(artifacts, releaseId, url)
expect(uploadMock).toBeCalledTimes(2) expect(uploadMock).toBeCalledTimes(2)
expect(uploadMock) expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1') .toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock) expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2') .toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(deleteMock).toBeCalledTimes(2)
expect(deleteMock).toBeCalledWith(1)
expect(deleteMock).toBeCalledWith(2)
}) })
function createUploader(): GithubArtifactUploader { it('replaces no artifacts when previous asset list empty', async () => {
mockDeleteSuccess()
mockListWithoutAssets()
mockUploadArtifact()
const uploader = createUploader(true)
await uploader.uploadArtifacts(artifacts, releaseId, url)
expect(uploadMock).toBeCalledTimes(2)
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(deleteMock).toBeCalledTimes(0)
})
it('retry when upload failed with 5xx response', async () => {
mockListWithoutAssets()
mockUploadArtifact(500, 2)
const uploader = createUploader(true)
await uploader.uploadArtifacts(artifacts, releaseId, url)
expect(uploadMock).toBeCalledTimes(4)
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(deleteMock).toBeCalledTimes(0)
})
it('abort when upload failed with 5xx response after 3 attemps', async () => {
mockListWithoutAssets()
mockUploadArtifact(500, 4)
const uploader = createUploader(true)
await uploader.uploadArtifacts(artifacts, releaseId, url)
expect(uploadMock).toBeCalledTimes(5)
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(deleteMock).toBeCalledTimes(0)
})
it('abort when upload failed with non-5xx response', async () => {
mockListWithoutAssets()
mockUploadArtifact(401, 2)
const uploader = createUploader(true)
await uploader.uploadArtifacts(artifacts, releaseId, url)
expect(uploadMock).toBeCalledTimes(2)
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(deleteMock).toBeCalledTimes(0)
})
it('throws error from replace', async () => {
mockDeleteError()
mockListWithAssets()
mockUploadArtifact()
const uploader = createUploader(true)
expect.hasAssertions()
try {
await uploader.uploadArtifacts(artifacts, releaseId, url)
} catch (error) {
expect(error).toEqual("error")
}
})
it('updates all artifacts, delete none', async () => {
mockDeleteError()
mockListWithAssets()
mockUploadArtifact()
const uploader = createUploader(false)
await uploader.uploadArtifacts(artifacts, releaseId, url)
expect(uploadMock).toBeCalledTimes(2)
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art1')
expect(uploadMock)
.toBeCalledWith(url, contentLength, 'raw', fileContents, 'art2')
expect(deleteMock).toBeCalledTimes(0)
})
function createUploader(replaces: boolean): GithubArtifactUploader {
const MockReleases = jest.fn<Releases, any>(() => { const MockReleases = jest.fn<Releases, any>(() => {
return { return {
getByTag: jest.fn(),
create: jest.fn(), create: jest.fn(),
deleteArtifact: deleteMock,
getByTag: jest.fn(),
listArtifactsForRelease: listArtifactsMock,
listReleases: jest.fn(),
update: jest.fn(), update: jest.fn(),
uploadArtifact: uploadMock uploadArtifact: uploadMock
} }
}) })
return new GithubArtifactUploader(new MockReleases()) return new GithubArtifactUploader(new MockReleases(), replaces)
}
function mockDeleteError(): any {
deleteMock.mockRejectedValue("error")
}
function mockDeleteSuccess(): any {
deleteMock.mockResolvedValue({})
}
function mockListWithAssets() {
listArtifactsMock.mockResolvedValue({
data: [
{
name: "art1",
id: 1
},
{
name: "art2",
id: 2
}
]
})
}
function mockListWithoutAssets() {
listArtifactsMock.mockResolvedValue({ data: [] })
}
function mockUploadArtifact(status: number = 200, failures: number = 0) {
const error = new RequestError(`HTTP ${status}`, status, { headers: {}, request: { method: 'GET', url: '', headers: {} } })
for (let index = 0; index < failures; index++) {
uploadMock.mockRejectedValueOnce(error)
}
uploadMock.mockResolvedValue({})
} }
}); });

View File

@@ -144,6 +144,17 @@ describe('Inputs', () => {
}) })
}) })
describe('replacesArtifacts', () => {
it('returns false', () => {
expect(inputs.replacesArtifacts).toBe(false)
})
it('returns true', () => {
mockGetInput.mockReturnValue('true')
expect(inputs.replacesArtifacts).toBe(true)
})
})
describe('tag', () => { describe('tag', () => {
it('returns input tag', () => { it('returns input tag', () => {
mockGetInput.mockReturnValue('tag') mockGetInput.mockReturnValue('tag')

View File

@@ -6,6 +6,7 @@ inputs:
description: 'An optional flag which indicates if we should update a release if it already exists. Defaults to false.' description: 'An optional flag which indicates if we should update a release if it already exists. Defaults to false.'
default: '' default: ''
artifact: artifact:
deprecationMessage: Use 'artifacts' instead.
description: 'An optional set of paths representing artifacts to upload to the release. This may be a single path or a comma delimited list of paths (or globs)' description: 'An optional set of paths representing artifacts to upload to the release. This may be a single path or a comma delimited list of paths (or globs)'
default: '' default: ''
artifacts: artifacts:
@@ -31,7 +32,10 @@ inputs:
default: '' default: ''
prerelease: prerelease:
description: "Optionally marks this release as prerelease. Set to true to enable." description: "Optionally marks this release as prerelease. Set to true to enable."
default: '' default: ''
replacesArtifacts:
description: "Indicates if existing release artifacts should be replaced. Defaults to true."
default: 'true'
tag: tag:
description: 'An optional tag for the release. If this is omitted the git ref will be used (if it is a tag).' description: 'An optional tag for the release. If this is omitted the git ref will be used (if it is a tag).'
default: '' default: ''

View File

@@ -1,13 +1,4 @@
"use strict"; "use strict";
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
return new (P || (P = Promise))(function (resolve, reject) {
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
step((generator = generator.apply(thisArg, _arguments || [])).next());
});
};
Object.defineProperty(exports, "__esModule", { value: true }); Object.defineProperty(exports, "__esModule", { value: true });
const ErrorMessage_1 = require("./ErrorMessage"); const ErrorMessage_1 = require("./ErrorMessage");
class Action { class Action {
@@ -16,72 +7,62 @@ class Action {
this.releases = releases; this.releases = releases;
this.uploader = uploader; this.uploader = uploader;
} }
perform() { async perform() {
return __awaiter(this, void 0, void 0, function* () { const releaseResponse = await this.createOrUpdateRelease();
const uploadUrl = yield this.createOrUpdateRelease(); const releaseId = releaseResponse.id;
const artifacts = this.inputs.artifacts; const uploadUrl = releaseResponse.upload_url;
if (artifacts.length > 0) { const artifacts = this.inputs.artifacts;
yield this.uploader.uploadArtifacts(artifacts, uploadUrl); if (artifacts.length > 0) {
} await this.uploader.uploadArtifacts(artifacts, releaseId, uploadUrl);
}); }
} }
createOrUpdateRelease() { async createOrUpdateRelease() {
return __awaiter(this, void 0, void 0, function* () { if (this.inputs.allowUpdates) {
if (this.inputs.allowUpdates) { try {
try { const getResponse = await this.releases.getByTag(this.inputs.tag);
const getResponse = yield this.releases.getByTag(this.inputs.tag); return await this.updateRelease(getResponse.data.id);
return yield this.updateRelease(getResponse.data.id); }
catch (error) {
if (this.noPublishedRelease(error)) {
return await this.updateDraftOrCreateRelease();
} }
catch (error) { else {
if (this.noPublishedRelease(error)) { throw error;
return yield this.updateDraftOrCreateRelease();
}
else {
throw error;
}
} }
} }
else { }
return yield this.createRelease(); else {
} return await this.createRelease();
}); }
} }
updateRelease(id) { async updateRelease(id) {
return __awaiter(this, void 0, void 0, function* () { const response = await this.releases.update(id, this.inputs.tag, this.inputs.body, this.inputs.commit, this.inputs.draft, this.inputs.name, this.inputs.prerelease);
const response = yield this.releases.update(id, this.inputs.tag, this.inputs.body, this.inputs.commit, this.inputs.draft, this.inputs.name, this.inputs.prerelease); return response.data;
return response.data.upload_url;
});
} }
noPublishedRelease(error) { noPublishedRelease(error) {
const errorMessage = new ErrorMessage_1.ErrorMessage(error); const errorMessage = new ErrorMessage_1.ErrorMessage(error);
return errorMessage.status == 404; return errorMessage.status == 404;
} }
updateDraftOrCreateRelease() { async updateDraftOrCreateRelease() {
return __awaiter(this, void 0, void 0, function* () { const draftReleaseId = await this.findMatchingDraftReleaseId();
const draftReleaseId = yield this.findMatchingDraftReleaseId(); if (draftReleaseId) {
if (draftReleaseId) { return await this.updateRelease(draftReleaseId);
return yield this.updateRelease(draftReleaseId); }
} else {
else { return await this.createRelease();
return yield this.createRelease(); }
}
});
} }
findMatchingDraftReleaseId() { async findMatchingDraftReleaseId() {
var _a; var _a;
return __awaiter(this, void 0, void 0, function* () { const tag = this.inputs.tag;
const tag = this.inputs.tag; const response = await this.releases.listReleases();
const response = yield this.releases.listReleases(); const releases = response.data;
const releases = response.data; const draftRelease = releases.find(release => release.draft && release.tag_name == tag);
const draftRelease = releases.find(release => release.draft && release.tag_name == tag); return (_a = draftRelease) === null || _a === void 0 ? void 0 : _a.id;
return (_a = draftRelease) === null || _a === void 0 ? void 0 : _a.id;
});
} }
createRelease() { async createRelease() {
return __awaiter(this, void 0, void 0, function* () { const response = await this.releases.create(this.inputs.tag, this.inputs.body, this.inputs.commit, this.inputs.draft, this.inputs.name, this.inputs.prerelease);
const response = yield this.releases.create(this.inputs.tag, this.inputs.body, this.inputs.commit, this.inputs.draft, this.inputs.name, this.inputs.prerelease); return response.data;
return response.data.upload_url;
});
} }
} }
exports.Action = Action; exports.Action = Action;

View File

@@ -1,13 +1,4 @@
"use strict"; "use strict";
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
return new (P || (P = Promise))(function (resolve, reject) {
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
step((generator = generator.apply(thisArg, _arguments || [])).next());
});
};
var __importStar = (this && this.__importStar) || function (mod) { var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod; if (mod && mod.__esModule) return mod;
var result = {}; var result = {};
@@ -18,21 +9,47 @@ var __importStar = (this && this.__importStar) || function (mod) {
Object.defineProperty(exports, "__esModule", { value: true }); Object.defineProperty(exports, "__esModule", { value: true });
const core = __importStar(require("@actions/core")); const core = __importStar(require("@actions/core"));
class GithubArtifactUploader { class GithubArtifactUploader {
constructor(releases) { constructor(releases, replacesExistingArtifacts = true) {
this.releases = releases; this.releases = releases;
this.replacesExistingArtifacts = replacesExistingArtifacts;
} }
uploadArtifacts(artifacts, uploadUrl) { async uploadArtifacts(artifacts, releaseId, uploadUrl) {
return __awaiter(this, void 0, void 0, function* () { if (this.replacesExistingArtifacts) {
artifacts.forEach((artifact) => __awaiter(this, void 0, void 0, function* () { await this.deleteUpdatedArtifacts(artifacts, releaseId);
try { }
yield this.releases.uploadArtifact(uploadUrl, artifact.contentLength, artifact.contentType, artifact.readFile(), artifact.name); for (const artifact of artifacts) {
} await this.uploadArtifact(artifact, uploadUrl);
catch (error) { }
const message = `Failed to upload artifact ${artifact.name}. Does it already exist?`; }
core.warning(message); async uploadArtifact(artifact, uploadUrl, retry = 3) {
} try {
})); core.debug(`Uploading artifact ${artifact.name}...`);
await this.releases.uploadArtifact(uploadUrl, artifact.contentLength, artifact.contentType, artifact.readFile(), artifact.name);
}
catch (error) {
if (error.status >= 500 && retry > 0) {
core.warning(`Failed to upload artifact ${artifact.name}. ${error.message}. Retrying...`);
await this.uploadArtifact(artifact, uploadUrl, retry - 1);
}
else {
core.warning(`Failed to upload artifact ${artifact.name}. ${error.message}.`);
}
}
}
async deleteUpdatedArtifacts(artifacts, releaseId) {
const response = await this.releases.listArtifactsForRelease(releaseId);
const releaseAssets = response.data;
const assetByName = {};
releaseAssets.forEach(asset => {
assetByName[asset.name] = asset;
}); });
for (const artifact of artifacts) {
const asset = assetByName[artifact.name];
if (asset) {
core.debug(`Deleting existing artifact ${artifact.name}...`);
await this.releases.deleteArtifact(asset.id);
}
}
} }
} }
exports.GithubArtifactUploader = GithubArtifactUploader; exports.GithubArtifactUploader = GithubArtifactUploader;

View File

@@ -59,8 +59,12 @@ class CoreInputs {
return this.tag; return this.tag;
} }
get prerelease() { get prerelease() {
const draft = core.getInput('prerelease'); const preRelease = core.getInput('prerelease');
return draft == 'true'; return preRelease == 'true';
}
get replacesArtifacts() {
const replaces = core.getInput('replacesArtifacts');
return replaces == 'true';
} }
get tag() { get tag() {
const tag = core.getInput('tag'); const tag = core.getInput('tag');

View File

@@ -1,13 +1,4 @@
"use strict"; "use strict";
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
return new (P || (P = Promise))(function (resolve, reject) {
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
step((generator = generator.apply(thisArg, _arguments || [])).next());
});
};
var __importStar = (this && this.__importStar) || function (mod) { var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod; if (mod && mod.__esModule) return mod;
var result = {}; var result = {};
@@ -24,17 +15,15 @@ const Action_1 = require("./Action");
const ArtifactUploader_1 = require("./ArtifactUploader"); const ArtifactUploader_1 = require("./ArtifactUploader");
const ArtifactGlobber_1 = require("./ArtifactGlobber"); const ArtifactGlobber_1 = require("./ArtifactGlobber");
const ErrorMessage_1 = require("./ErrorMessage"); const ErrorMessage_1 = require("./ErrorMessage");
function run() { async function run() {
return __awaiter(this, void 0, void 0, function* () { try {
try { const action = createAction();
const action = createAction(); await action.perform();
yield action.perform(); }
} catch (error) {
catch (error) { const errorMessage = new ErrorMessage_1.ErrorMessage(error);
const errorMessage = new ErrorMessage_1.ErrorMessage(error); core.setFailed(errorMessage.toString());
core.setFailed(errorMessage.toString()); }
}
});
} }
function createAction() { function createAction() {
const token = core.getInput('token'); const token = core.getInput('token');
@@ -43,7 +32,7 @@ function createAction() {
const globber = new ArtifactGlobber_1.FileArtifactGlobber(); const globber = new ArtifactGlobber_1.FileArtifactGlobber();
const inputs = new Inputs_1.CoreInputs(globber, context); const inputs = new Inputs_1.CoreInputs(globber, context);
const releases = new Releases_1.GithubReleases(context, git); const releases = new Releases_1.GithubReleases(context, git);
const uploader = new ArtifactUploader_1.GithubArtifactUploader(releases); const uploader = new ArtifactUploader_1.GithubArtifactUploader(releases, inputs.replacesArtifacts);
return new Action_1.Action(inputs, releases, uploader); return new Action_1.Action(inputs, releases, uploader);
} }
run(); run();

View File

@@ -1,76 +1,71 @@
"use strict"; "use strict";
var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
return new (P || (P = Promise))(function (resolve, reject) {
function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
step((generator = generator.apply(thisArg, _arguments || [])).next());
});
};
Object.defineProperty(exports, "__esModule", { value: true }); Object.defineProperty(exports, "__esModule", { value: true });
class GithubReleases { class GithubReleases {
constructor(context, git) { constructor(context, git) {
this.context = context; this.context = context;
this.git = git; this.git = git;
} }
create(tag, body, commitHash, draft, name, prerelease) { async create(tag, body, commitHash, draft, name, prerelease) {
return __awaiter(this, void 0, void 0, function* () { return this.git.repos.createRelease({
return this.git.repos.createRelease({ body: body,
body: body, name: name,
name: name, draft: draft,
draft: draft, owner: this.context.repo.owner,
owner: this.context.repo.owner, prerelease: prerelease,
prerelease: prerelease, repo: this.context.repo.repo,
repo: this.context.repo.repo, target_commitish: commitHash,
target_commitish: commitHash, tag_name: tag
tag_name: tag
});
}); });
} }
listReleases() { async deleteArtifact(assetId) {
return __awaiter(this, void 0, void 0, function* () { return this.git.repos.deleteReleaseAsset({
return this.git.repos.listReleases({ asset_id: assetId,
owner: this.context.repo.owner, owner: this.context.repo.owner,
repo: this.context.repo.repo repo: this.context.repo.repo
});
}); });
} }
getByTag(tag) { async listArtifactsForRelease(releaseId) {
return __awaiter(this, void 0, void 0, function* () { return this.git.repos.listAssetsForRelease({
return this.git.repos.getReleaseByTag({ owner: this.context.repo.owner,
owner: this.context.repo.owner, release_id: releaseId,
repo: this.context.repo.repo, repo: this.context.repo.repo
tag: tag
});
}); });
} }
update(id, tag, body, commitHash, draft, name, prerelease) { async listReleases() {
return __awaiter(this, void 0, void 0, function* () { return this.git.repos.listReleases({
return this.git.repos.updateRelease({ owner: this.context.repo.owner,
release_id: id, repo: this.context.repo.repo
body: body,
name: name,
draft: draft,
owner: this.context.repo.owner,
prerelease: prerelease,
repo: this.context.repo.repo,
target_commitish: commitHash,
tag_name: tag
});
}); });
} }
uploadArtifact(assetUrl, contentLength, contentType, file, name) { async getByTag(tag) {
return __awaiter(this, void 0, void 0, function* () { return this.git.repos.getReleaseByTag({
return this.git.repos.uploadReleaseAsset({ owner: this.context.repo.owner,
url: assetUrl, repo: this.context.repo.repo,
headers: { tag: tag
"content-length": contentLength, });
"content-type": contentType }
}, async update(id, tag, body, commitHash, draft, name, prerelease) {
file: file, return this.git.repos.updateRelease({
name: name release_id: id,
}); body: body,
name: name,
draft: draft,
owner: this.context.repo.owner,
prerelease: prerelease,
repo: this.context.repo.repo,
target_commitish: commitHash,
tag_name: tag
});
}
async uploadArtifact(assetUrl, contentLength, contentType, file, name) {
return this.git.repos.uploadReleaseAsset({
url: assetUrl,
headers: {
"content-length": contentLength,
"content-type": contentType
},
file: file,
name: name
}); });
} }
} }

35
node_modules/.yarn-integrity generated vendored
View File

@@ -1,5 +1,5 @@
{ {
"systemParams": "darwin-x64-72", "systemParams": "darwin-x64-79",
"modulesFolders": [ "modulesFolders": [
"node_modules" "node_modules"
], ],
@@ -646,11 +646,36 @@
"files": [], "files": [],
"artifacts": { "artifacts": {
"fsevents@1.2.9": [ "fsevents@1.2.9": [
"lib", "build",
"lib/binding", "build/.target.mk",
"build/Makefile",
"build/Release",
"build/Release/.deps",
"build/Release/.deps/Release",
"build/Release/.deps/Release/.node.d",
"build/Release/.deps/Release/fse.node.d",
"build/Release/.deps/Release/obj.target",
"build/Release/.deps/Release/obj.target/action_after_build.stamp.d",
"build/Release/.deps/Release/obj.target/fse",
"build/Release/.deps/Release/obj.target/fse/fsevents.o.d",
"build/Release/.deps/Users",
"build/Release/.deps/Users/nickcipollo",
"build/Release/.deps/Users/nickcipollo/src",
"build/Release/.deps/Users/nickcipollo/src/release-action",
"build/Release/.node",
"build/Release/fse.node",
"build/Release/obj.target",
"build/Release/obj.target/action_after_build.stamp",
"build/Release/obj.target/fse",
"build/Release/obj.target/fse/fsevents.o",
"build/action_after_build.target.mk",
"build/binding.Makefile",
"build/config.gypi",
"build/fse.target.mk",
"build/gyp-mac-tool",
"lib/binding/Release", "lib/binding/Release",
"lib/binding/Release/node-v72-darwin-x64", "lib/binding/Release/node-v79-darwin-x64",
"lib/binding/Release/node-v72-darwin-x64/fse.node" "lib/binding/Release/node-v79-darwin-x64/fse.node"
] ]
} }
} }

View File

@@ -1,5 +1,6 @@
import { Inputs } from "./Inputs"; import { Inputs } from "./Inputs";
import { Releases } from "./Releases"; import { Releases } from "./Releases";
import { ReposCreateReleaseResponse } from "@octokit/rest";
import { ArtifactUploader } from "./ArtifactUploader"; import { ArtifactUploader } from "./ArtifactUploader";
import { ErrorMessage } from "./ErrorMessage"; import { ErrorMessage } from "./ErrorMessage";
@@ -15,15 +16,17 @@ export class Action {
} }
async perform() { async perform() {
const uploadUrl = await this.createOrUpdateRelease() const releaseResponse = await this.createOrUpdateRelease();
const releaseId = releaseResponse.id
const uploadUrl = releaseResponse.upload_url
const artifacts = this.inputs.artifacts const artifacts = this.inputs.artifacts
if (artifacts.length > 0) { if (artifacts.length > 0) {
await this.uploader.uploadArtifacts(artifacts, uploadUrl) await this.uploader.uploadArtifacts(artifacts, releaseId, uploadUrl)
} }
} }
private async createOrUpdateRelease(): Promise<string> { private async createOrUpdateRelease(): Promise<ReposCreateReleaseResponse> {
if (this.inputs.allowUpdates) { if (this.inputs.allowUpdates) {
try { try {
const getResponse = await this.releases.getByTag(this.inputs.tag) const getResponse = await this.releases.getByTag(this.inputs.tag)
@@ -40,7 +43,7 @@ export class Action {
} }
} }
private async updateRelease(id: number): Promise<string> { private async updateRelease(id: number): Promise<ReposCreateReleaseResponse> {
const response = await this.releases.update( const response = await this.releases.update(
id, id,
this.inputs.tag, this.inputs.tag,
@@ -51,7 +54,7 @@ export class Action {
this.inputs.prerelease this.inputs.prerelease
) )
return response.data.upload_url return response.data
} }
private noPublishedRelease(error: any): boolean { private noPublishedRelease(error: any): boolean {
@@ -59,7 +62,7 @@ export class Action {
return errorMessage.status == 404 return errorMessage.status == 404
} }
private async updateDraftOrCreateRelease(): Promise<string> { private async updateDraftOrCreateRelease(): Promise<ReposCreateReleaseResponse> {
const draftReleaseId = await this.findMatchingDraftReleaseId() const draftReleaseId = await this.findMatchingDraftReleaseId()
if (draftReleaseId) { if (draftReleaseId) {
return await this.updateRelease(draftReleaseId) return await this.updateRelease(draftReleaseId)
@@ -77,7 +80,7 @@ export class Action {
return draftRelease?.id return draftRelease?.id
} }
private async createRelease(): Promise<string> { private async createRelease(): Promise<ReposCreateReleaseResponse> {
const response = await this.releases.create( const response = await this.releases.create(
this.inputs.tag, this.inputs.tag,
this.inputs.body, this.inputs.body,
@@ -87,6 +90,6 @@ export class Action {
this.inputs.prerelease this.inputs.prerelease
) )
return response.data.upload_url return response.data
} }
} }

View File

@@ -1,30 +1,61 @@
import * as core from '@actions/core'; import * as core from '@actions/core';
import { Artifact } from "./Artifact"; import { Artifact } from "./Artifact";
import { Releases } from "./Releases"; import { Releases } from "./Releases";
import { ReposListAssetsForReleaseResponseItem } from "@octokit/rest";
export interface ArtifactUploader { export interface ArtifactUploader {
uploadArtifacts(artifacts: Artifact[], uploadUrl: string): Promise<void> uploadArtifacts(artifacts: Artifact[], releaseId: number, uploadUrl: string): Promise<void>
} }
export class GithubArtifactUploader implements ArtifactUploader { export class GithubArtifactUploader implements ArtifactUploader {
private releases: Releases constructor(
private releases: Releases,
constructor(releases: Releases) { private replacesExistingArtifacts: boolean = true,
this.releases = releases ) {
} }
async uploadArtifacts(artifacts: Artifact[], uploadUrl: string) { async uploadArtifacts(artifacts: Artifact[],
artifacts.forEach(async artifact => { releaseId: number,
try { uploadUrl: string): Promise<void> {
await this.releases.uploadArtifact(uploadUrl, if (this.replacesExistingArtifacts) {
artifact.contentLength, await this.deleteUpdatedArtifacts(artifacts, releaseId)
artifact.contentType, }
artifact.readFile(), for (const artifact of artifacts) {
artifact.name) await this.uploadArtifact(artifact, uploadUrl)
} catch(error) { }
const message = `Failed to upload artifact ${artifact.name}. Does it already exist?` }
core.warning(message)
private async uploadArtifact(artifact: Artifact, uploadUrl: string, retry = 3) {
try {
core.debug(`Uploading artifact ${artifact.name}...`)
await this.releases.uploadArtifact(uploadUrl,
artifact.contentLength,
artifact.contentType,
artifact.readFile(),
artifact.name)
} catch (error) {
if (error.status >= 500 && retry > 0) {
core.warning(`Failed to upload artifact ${artifact.name}. ${error.message}. Retrying...`)
await this.uploadArtifact(artifact, uploadUrl, retry - 1)
} else {
core.warning(`Failed to upload artifact ${artifact.name}. ${error.message}.`)
} }
}
}
private async deleteUpdatedArtifacts(artifacts: Artifact[], releaseId: number): Promise<void> {
const response = await this.releases.listArtifactsForRelease(releaseId)
const releaseAssets = response.data
const assetByName: Record<string, ReposListAssetsForReleaseResponseItem> = {}
releaseAssets.forEach(asset => {
assetByName[asset.name] = asset
}); });
for (const artifact of artifacts) {
const asset = assetByName[artifact.name]
if (asset) {
core.debug(`Deleting existing artifact ${artifact.name}...`)
await this.releases.deleteArtifact(asset.id)
}
}
} }
} }

View File

@@ -12,6 +12,7 @@ export interface Inputs {
readonly draft: boolean readonly draft: boolean
readonly name: string readonly name: string
readonly prerelease: boolean readonly prerelease: boolean
readonly replacesArtifacts: boolean
readonly tag: string readonly tag: string
readonly token: string readonly token: string
} }
@@ -79,8 +80,13 @@ export class CoreInputs implements Inputs {
} }
get prerelease(): boolean { get prerelease(): boolean {
const draft = core.getInput('prerelease') const preRelease = core.getInput('prerelease')
return draft == 'true' return preRelease == 'true'
}
get replacesArtifacts(): boolean {
const replaces = core.getInput('replacesArtifacts')
return replaces == 'true'
} }
get tag(): string { get tag(): string {

View File

@@ -25,7 +25,7 @@ function createAction(): Action {
const inputs = new CoreInputs(globber, context) const inputs = new CoreInputs(globber, context)
const releases = new GithubReleases(context, git) const releases = new GithubReleases(context, git)
const uploader = new GithubArtifactUploader(releases) const uploader = new GithubArtifactUploader(releases, inputs.replacesArtifacts)
return new Action(inputs, releases, uploader) return new Action(inputs, releases, uploader)
} }

View File

@@ -1,6 +1,6 @@
import { Context } from "@actions/github/lib/context"; import { Context } from "@actions/github/lib/context";
import { GitHub } from "@actions/github"; import { GitHub } from "@actions/github";
import { AnyResponse, Response, ReposCreateReleaseResponse, ReposGetReleaseByTagResponse, ReposListReleasesResponse } from "@octokit/rest"; import { AnyResponse, Response, ReposDeleteReleaseAssetResponse, ReposListAssetsForReleaseResponse, ReposCreateReleaseResponse, ReposGetReleaseByTagResponse, ReposListReleasesResponse } from "@octokit/rest";
export interface Releases { export interface Releases {
create( create(
@@ -12,8 +12,12 @@ export interface Releases {
prerelease?: boolean prerelease?: boolean
): Promise<Response<ReposCreateReleaseResponse>> ): Promise<Response<ReposCreateReleaseResponse>>
deleteArtifact(assetId: number): Promise<Response<ReposDeleteReleaseAssetResponse>>
getByTag(tag: string): Promise<Response<ReposGetReleaseByTagResponse>> getByTag(tag: string): Promise<Response<ReposGetReleaseByTagResponse>>
listArtifactsForRelease(releaseId: number): Promise<Response<ReposListAssetsForReleaseResponse>>
listReleases(): Promise<Response<ReposListReleasesResponse>> listReleases(): Promise<Response<ReposListReleasesResponse>>
update( update(
@@ -64,6 +68,26 @@ export class GithubReleases implements Releases {
}) })
} }
async deleteArtifact(
assetId: number
): Promise<Response<ReposDeleteReleaseAssetResponse>> {
return this.git.repos.deleteReleaseAsset({
asset_id: assetId,
owner: this.context.repo.owner,
repo: this.context.repo.repo
})
}
async listArtifactsForRelease(
releaseId: number
): Promise<Response<ReposListAssetsForReleaseResponse>> {
return this.git.repos.listAssetsForRelease({
owner: this.context.repo.owner,
release_id: releaseId,
repo: this.context.repo.repo
})
}
async listReleases(): Promise<Response<ReposListReleasesResponse>> { async listReleases(): Promise<Response<ReposListReleasesResponse>> {
return this.git.repos.listReleases({ return this.git.repos.listReleases({
owner: this.context.repo.owner, owner: this.context.repo.owner,

View File

@@ -2,7 +2,7 @@
"compilerOptions": { "compilerOptions": {
/* Basic Options */ /* Basic Options */
// "incremental": true, /* Enable incremental compilation */ // "incremental": true, /* Enable incremental compilation */
"target": "es6", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ "target": "es2019", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */
"module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */
// "allowJs": true, /* Allow javascript files to be compiled. */ // "allowJs": true, /* Allow javascript files to be compiled. */
// "checkJs": true, /* Report errors in .js files. */ // "checkJs": true, /* Report errors in .js files. */