Cleanup error classes and CI

src/Action.ts

@@ -1,7 +1,7 @@
 import {Inputs} from "./Inputs";
 import {CreateReleaseResponse, Releases, UpdateReleaseResponse} from "./Releases";
 import {ArtifactUploader} from "./ArtifactUploader";
-import {ErrorMessage} from "./ErrorMessage";
+import {GithubError} from "./GithubError";
 
 export class Action {
     private inputs: Inputs
@@ -55,8 +55,8 @@ export class Action {
     }
 
     private static noPublishedRelease(error: any): boolean {
-        const errorMessage = new ErrorMessage(error)
-        return errorMessage.status == 404
+        const githubError = new GithubError(error)
+        return githubError.status == 404
     }
 
     private async updateDraftOrCreateRelease(): Promise<CreateReleaseResponse | UpdateReleaseResponse> {

src/ErrorMessage.ts

@@ -1,44 +0,0 @@
-import {GithubError} from "./GithubError"
-
-export class ErrorMessage {
-    private error: any
-    private githubErrors: GithubError[]
-
-    constructor(error: any) {
-        this.error = error
-        this.githubErrors = this.generateGithubErrors()
-    }
-
-    private generateGithubErrors(): GithubError[] {
-        const errors = this.error.errors
-        if (errors instanceof Array) {
-            return errors.map((err) => new GithubError(err))
-        } else {
-            return []
-        }
-    }
-
-    get status(): number {
-        return this.error.status
-    }
-
-    hasErrorWithCode(code: String): boolean {
-        return this.githubErrors.some((err) => err.code == code)
-    }
-
-    toString(): string {
-        const message = this.error.message
-        const errors = this.githubErrors
-        const status = this.status
-        if (errors.length > 0) {
-            return `Error ${status}: ${message}\nErrors:\n${this.errorBulletedList(errors)}`
-        } else {
-            return `Error ${status}: ${message}`
-        }
-    }
-
-    private errorBulletedList(errors: GithubError[]): string {
-        return errors.map((err) => `- ${err}`).join("\n")
-    }
-}
-

src/GithubError.ts

@@ -1,65 +1,44 @@
+import {GithubErrorDetail} from "./GithubErrorDetail"
+
 export class GithubError {
-    private error: any;
+    private error: any
+    private readonly githubErrors: GithubErrorDetail[]
 
     constructor(error: any) {
         this.error = error
+        this.githubErrors = this.generateGithubErrors()
     }
 
-    get code(): string {
-        return this.error.code
+    private generateGithubErrors(): GithubErrorDetail[] {
+        const errors = this.error.errors
+        if (errors instanceof Array) {
+            return errors.map((err) => new GithubErrorDetail(err))
+        } else {
+            return []
+        }
+    }
+
+    get status(): number {
+        return this.error.status
+    }
+
+    hasErrorWithCode(code: String): boolean {
+        return this.githubErrors.some((err) => err.code == code)
     }
 
     toString(): string {
-        const code = this.error.code
-        switch (code) {
-            case 'missing':
-                return this.missingResourceMessage()
-            case 'missing_field':
-                return this.missingFieldMessage()
-            case 'invalid':
-                return this.invalidFieldMessage()
-            case 'already_exists':
-                return this.resourceAlreadyExists()
-            default:
-                return this.customErrorMessage()
-        }
-    }
-
-    private customErrorMessage(): string {
-        const message = this.error.message;
-        const documentation = this.error.documentation_url
-
-        let documentationMessage: string
-        if (documentation) {
-            documentationMessage = `\nPlease see ${documentation}.`
+        const message = this.error.message
+        const errors = this.githubErrors
+        const status = this.status
+        if (errors.length > 0) {
+            return `Error ${status}: ${message}\nErrors:\n${this.errorBulletedList(errors)}`
         } else {
-            documentationMessage = ""
+            return `Error ${status}: ${message}`
         }
-
-        return `${message}${documentationMessage}`
     }
 
-    private invalidFieldMessage(): string {
-        const resource = this.error.resource
-        const field = this.error.field
-
-        return `The ${field} field on ${resource} is an invalid format.`
-    }
-
-    private missingResourceMessage(): string {
-        const resource = this.error.resource
-        return `${resource} does not exist.`
-    }
-
-    private missingFieldMessage(): string {
-        const resource = this.error.resource
-        const field = this.error.field
-
-        return `The ${field} field on ${resource} is missing.`
-    }
-
-    private resourceAlreadyExists(): string {
-        const resource = this.error.resource
-        return `${resource} already exists.`
+    private errorBulletedList(errors: GithubErrorDetail[]): string {
+        return errors.map((err) => `- ${err}`).join("\n")
     }
 }
+

src/GithubErrorDetail.ts

@@ -0,0 +1,65 @@
+export class GithubErrorDetail {
+    private error: any;
+
+    constructor(error: any) {
+        this.error = error
+    }
+
+    get code(): string {
+        return this.error.code
+    }
+
+    toString(): string {
+        const code = this.error.code
+        switch (code) {
+            case 'missing':
+                return this.missingResourceMessage()
+            case 'missing_field':
+                return this.missingFieldMessage()
+            case 'invalid':
+                return this.invalidFieldMessage()
+            case 'already_exists':
+                return this.resourceAlreadyExists()
+            default:
+                return this.customErrorMessage()
+        }
+    }
+
+    private customErrorMessage(): string {
+        const message = this.error.message;
+        const documentation = this.error.documentation_url
+
+        let documentationMessage: string
+        if (documentation) {
+            documentationMessage = `\nPlease see ${documentation}.`
+        } else {
+            documentationMessage = ""
+        }
+
+        return `${message}${documentationMessage}`
+    }
+
+    private invalidFieldMessage(): string {
+        const resource = this.error.resource
+        const field = this.error.field
+
+        return `The ${field} field on ${resource} is an invalid format.`
+    }
+
+    private missingResourceMessage(): string {
+        const resource = this.error.resource
+        return `${resource} does not exist.`
+    }
+
+    private missingFieldMessage(): string {
+        const resource = this.error.resource
+        const field = this.error.field
+
+        return `The ${field} field on ${resource} is missing.`
+    }
+
+    private resourceAlreadyExists(): string {
+        const resource = this.error.resource
+        return `${resource} already exists.`
+    }
+}

src/Main.ts

@@ -5,15 +5,15 @@ import { GithubReleases } from './Releases';
 import { Action } from './Action';
 import { GithubArtifactUploader } from './ArtifactUploader';
 import { FileArtifactGlobber } from './ArtifactGlobber';
-import { ErrorMessage } from './ErrorMessage';
+import { GithubError } from './GithubError';
 
 async function run() {
   try {
     const action = createAction()
     await action.perform()
   } catch (error) {
-    const errorMessage = new ErrorMessage(error)
-    core.setFailed(errorMessage.toString());
+    const githubError = new GithubError(error)
+    core.setFailed(githubError.toString());
   }
 }