Fixes #32 Globber will now expand tilde and warn if no results are found

__tests__/ArtifactGlobber.test.ts

@@ -1,19 +1,45 @@
+const warnMock = jest.fn()
+
 import { FileArtifactGlobber } from "../src/ArtifactGlobber"
 import { Globber } from "../src/Globber";
 import { Artifact } from "../src/Artifact";
+import untildify = require("untildify");
 
 const contentType = "raw"
+const globMock = jest.fn()
 const globResults = ["file1", "file2"]
 
+jest.mock('@actions/core', () => {
+    return {warning: warnMock};
+})
+
 describe("ArtifactGlobber", () => {
-    it("globs simple path", () => {
+    beforeEach(() => {
+        globMock.mockClear()
+    })
+
+    it("expands paths in which start with a ~", () => {
         const globber = createArtifactGlobber()
 
         const expectedArtifacts =
             globResults.map((path) => new Artifact(path, contentType))
 
+        expect(globber.globArtifactString('~/path', 'raw'))
+            .toEqual(expectedArtifacts)
+        expect(globMock).toBeCalledWith(untildify('~/path'))
+        expect(warnMock).not.toBeCalled()
+    })
+    
+    it("globs simple path", () => {
+        const globber = createArtifactGlobber()
+
+        const expectedArtifacts =
+            globResults.map((path) => new Artifact(path, contentType))
+        
         expect(globber.globArtifactString('path', 'raw'))
             .toEqual(expectedArtifacts)
+        expect(globMock).toBeCalledWith('path')
+        expect(warnMock).not.toBeCalled()
     })
 
     it("splits multiple paths", () => {
@@ -26,14 +52,29 @@ describe("ArtifactGlobber", () => {
 
         expect(globber.globArtifactString('path1,path2', 'raw'))
             .toEqual(expectedArtifacts)
+        expect(globMock).toBeCalledWith('path1')
+        expect(globMock).toBeCalledWith('path2')
+        expect(warnMock).not.toBeCalled()
     })
 
-    function createArtifactGlobber(): FileArtifactGlobber {
+    it("warns when no glob results are produced", () => {
+        const globber = createArtifactGlobber([])
+
+        const expectedArtifacts =
+            globResults.map((path) => new Artifact(path, contentType))
+
+        expect(globber.globArtifactString('path', 'raw'))
+            .toEqual([])
+        expect(warnMock).toBeCalled()
+    })
+
+    function createArtifactGlobber(results: string[] = globResults): FileArtifactGlobber {
         const MockGlobber = jest.fn<Globber, any>(() => {
             return {
-                glob: () => globResults
+                glob: globMock
             }
         })
+        globMock.mockReturnValue(results)
         return new FileArtifactGlobber(new MockGlobber())
     }
 })

__tests__/Integration.test.ts

@@ -3,8 +3,8 @@ import * as github from "@actions/github";
 import {Inputs} from "../src/Inputs";
 import {GithubReleases} from "../src/Releases";
 import {GithubArtifactUploader} from "../src/ArtifactUploader";
-import {Artifact} from "../src/Artifact";
 import * as path from "path";
+import {FileArtifactGlobber} from "../src/ArtifactGlobber";
 
 // This test is currently intended to be manually run during development. To run:
 // - Make sure you have an environment variable named GITHUB_TOKEN assigned to your token
@@ -27,28 +27,33 @@ describe.skip('Integration Test', () => {
     })
 
     function getInputs(): Inputs {
-        const artifactPath = path.join(__dirname, 'Integration.test.ts')
-        // new
         const MockInputs = jest.fn<Inputs, any>(() => {
             return {
                 allowUpdates: true,
-                artifacts: [new Artifact(artifactPath)],
-                createdReleaseBody: "release body",
-                createdReleaseName: "release name",
+                artifacts: artifacts(),
+                createdReleaseBody: "This release was generated by release-action's integration test",
+                createdReleaseName: "Releases Action Integration Test",
                 commit: "",
                 draft: false,
                 owner: "ncipollo",
-                prerelease: true,
+                prerelease: false,
                 replacesArtifacts: true,
                 repo: "actions-playground",
-                tag: "0.0.71",
+                tag: "release-action-test",
                 token: getToken(),
-                updatedReleaseBody: "updated body",
-                updatedReleaseName: "updated name"
+                updatedReleaseBody: "This release was generated by release-action's integration test",
+                updatedReleaseName: "Releases Action Integration Test"
             }
         })
         return new MockInputs();
     }
+    
+    function artifacts() {
+        const globber = new FileArtifactGlobber()
+        const artifactPath = path.join(__dirname, 'Integration.test.ts')
+        const artifactString = `~/Desktop/test.txt,blarg.tx, ${artifactPath}`
+        return globber.globArtifactString(artifactString, "raw")
+    }
 
     function getToken(): string {
         return process.env.GITHUB_TOKEN ?? ""